Skip to content

fix(plugin): batch achievement notifications to prevent text wall#1045

Merged
JeremyDev87 merged 1 commit into
masterfrom
fix/achievement-batch-1042
Mar 28, 2026
Merged

fix(plugin): batch achievement notifications to prevent text wall#1045
JeremyDev87 merged 1 commit into
masterfrom
fix/achievement-batch-1042

Conversation

@JeremyDev87

@JeremyDev87 JeremyDev87 commented Mar 28, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #1042

  • Add render_batch_celebration() to achievement_tracker.py — shows the top achievement in detail and summarises the rest as "+N more achievements unlocked!"
  • Update stop.py to call render_batch_celebration() instead of looping individual celebrations
  • Add i18n batch messages for en/ko/ja/zh/es

Test plan

  • test_empty_list — 0 achievements returns empty string
  • test_single_achievement — 1 achievement delegates to existing renderer
  • test_two_achievements — 2 achievements: detail + "+1 more"
  • test_three_achievements — 3 achievements: detail + "+2 more"
  • test_three_achievements_korean — Korean locale batch message
  • All existing 46 tests still pass (51 total)
  • MCP server tests pass (5308)
  • Plugin TS tests pass (71)

@JeremyDev87
fix(plugin): batch achievement notifications to prevent text wall (#1042
34ce243 
)

Add render_batch_celebration() that shows the top achievement in detail
and summarises the rest as "+N more achievements unlocked!" when multiple
achievements are unlocked simultaneously.
@JeremyDev87 JeremyDev87 added fix plugin packages/claude-code-plugin labels Mar 28, 2026
@vercel

vercel Bot commented Mar 28, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
codingbuddy-landing Ready Ready Preview, Comment Mar 28, 2026 0:46am

@JeremyDev87 JeremyDev87 self-assigned this Mar 28, 2026
@JeremyDev87 JeremyDev87 merged commit c1fa1c2 into master Mar 28, 2026
28 checks passed
@JeremyDev87 JeremyDev87 deleted the fix/achievement-batch-1042 branch March 28, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JeremyDev87 JeremyDev87

Labels

fix plugin packages/claude-code-plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(plugin): batch achievement notifications to prevent text wall

1 participant

@JeremyDev87